Skip to content

Fix IndexOutOfBoundsException when try to map inner hits with no results returned #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2021
Merged

Fix IndexOutOfBoundsException when try to map inner hits with no results returned #1998

merged 2 commits into from
Nov 23, 2021

Conversation

xhaggi
Copy link
Contributor

@xhaggi xhaggi commented Nov 16, 2021 •
edited
Loading

Fixes #1997

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our [issue tracker](https://github.
    com/spring-projects/spring-data-elasticsearch/issues)    . Add the issue number to the Closes #issue-number line below
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Closes #issue-number

@xhaggi xhaggi requested a review from sothawo November 16, 2021 07:28
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 16, 2021
@sothawo sothawo added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 21, 2021
@xhaggi xhaggi requested a review from sothawo November 23, 2021 13:18
@xhaggi
Copy link
Contributor Author

xhaggi commented Nov 23, 2021

@sothawo a backport to 4.2 and 4.3 would be great to get rid of the warning. Let me know if you want me to do that.

@sothawo sothawo merged commit 49324a3 into spring-projects:main Nov 23, 2021
sothawo pushed a commit that referenced this pull request Nov 23, 2021
@xhaggi @sothawo
Fix IndexOutOfBoundsException when try to map inner hits with no resu…
4f3aa52 
…lts returned.

Original Pull Request #1998
Closes #1997
Co-authored-by: Peter-Josef Meisch <[email protected]>

(cherry picked from commit 49324a3)
@xhaggi xhaggi deleted the issue/1997 branch November 24, 2021 08:54
xhaggi added a commit that referenced this pull request Nov 24, 2021
@xhaggi
Fix IndexOutOfBoundsException when try to map inner hits with no resu…
2aba7a5 
…lts returned.

Original Pull Request #1998
Closes #1997

(cherry picked from commit 49324a3)
xhaggi added a commit that referenced this pull request Nov 24, 2021
@xhaggi
Fix IndexOutOfBoundsException when try to map inner hits with no resu…
c688045 
…lts returned.

Original Pull Request #1998
Closes #1997

(cherry picked from commit 2aba7a5)
sothawo added a commit that referenced this pull request Dec 5, 2021
@sothawo
Fix IndexOutOfBoundsException when try to map inner hits with no resu…
083a38e 
…lts returned.

Original Pull Request #1998
Closes #1997
Co-authored-by: Peter-Josef Meisch <[email protected]>

(cherry picked from commit 49324a3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonLGVS AntonLGVS AntonLGVS left review comments

@sothawo sothawo Awaiting requested review from sothawo

Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IndexOutOfBoundsException when try to map inner hits with no results returned
4 participants
@xhaggi @AntonLGVS @sothawo @spring-projects-issues